Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kubernetes package version 1.10. #74

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

shrinandj
Copy link
Contributor

Had to use them as [[overrides]] and not directly as [[constraints]] because
argo still uses version v1.9.

Testing done:

  1. Builds worked just fine.
  2. Unit tests worked just fine.
  3. Ran the controller and a couple of sensors. They worked too.

Had to use them as [[overrides]] and not directly as [[constraints]] because
argo still uses version v1.9.

Testing done:

1. Builds worked just fine.
2. Unit tests worked just fine.
3. Ran the controller and a couple of sensors. They worked too.
@shrinandj shrinandj requested a review from magaldima July 27, 2018 17:21
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@magaldima magaldima merged commit 0b73937 into argoproj:master Jul 27, 2018
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Had to use them as [[overrides]] and not directly as [[constraints]] because
argo still uses version v1.9.

Testing done:

1. Builds worked just fine.
2. Unit tests worked just fine.
3. Ran the controller and a couple of sensors. They worked too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants