Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute filterData only if data filter is specified. #83

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

shrinandj
Copy link
Contributor

Fixed unit tests.

Testing Done:

  1. Unit tests pass
  2. Added an example sensor. It failed prior to this change. Succeeded after.

Closes #82

Fixed unit tests.

Testing Done:

1. Unit tests pass
2. Added an example sensor. It failed prior to this change. Succeeded after.

Closes argoproj#82
@shrinandj shrinandj requested a review from magaldima August 7, 2018 03:38
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you!

@magaldima magaldima merged commit 38548a7 into argoproj:master Aug 7, 2018
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Fixed unit tests.

Testing Done:

1. Unit tests pass
2. Added an example sensor. It failed prior to this change. Succeeded after.

Closes argoproj#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants