Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend resource eventsource field filter. Closes #913 #915

Merged
merged 4 commits into from
Oct 20, 2020
Merged

feat: extend resource eventsource field filter. Closes #913 #915

merged 4 commits into from
Oct 20, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Oct 15, 2020 •
edited
Loading

This PR changed the implementation of field filter of resource EventSource.

Field field used to utilize K8s field selector, but it:

  1. Only limited fields (such as metadata.name, status.phase) can be used for filtering, you can not do something like
kubectl get ingress --field-selector foo.bar=baz
  1. The value needs to be a fixed string, no regex support.

The PR makes above requirements supported.

In term of operators, same as K8s field selector, only =, == and != are supported.

Checklist:

  • Either (a) I've created an feature request and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Closes #913

@whynowy whynowy requested a review from VaibhavPage October 15, 2020 17:27
VaibhavPage
VaibhavPage approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VaibhavPage VaibhavPage merged commit c1a7453 into argoproj:master Oct 20, 2020
@whynowy whynowy deleted the resource_filter branch October 20, 2020 16:22
whynowy added a commit to RiyaJohn/argo-events that referenced this pull request Nov 17, 2020
@whynowy
feat: extend resource eventsource field filter. Closes argoproj#913 (a…
6b0adf4 
…rgoproj#915)

* feat: extend resource eventsource field filter. Closes argoproj#913

* re-run codegen with lastest panddoc

* infof

Signed-off-by: Derek Wang <whynowy@gmail.com>
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@whynowy
feat: extend resource eventsource field filter. Closes argoproj#913 (a…
5bb0e88 
…rgoproj#915)

* feat: extend resource eventsource field filter. Closes argoproj#913

* re-run codegen with lastest panddoc

* infof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavPage VaibhavPage VaibhavPage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field selector regex support in Resource EventSource
2 participants
@whynowy @VaibhavPage