Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow controller pod labels do not match upstream #2774

Closed
tico24 opened this issue Jun 18, 2024 · 0 comments · Fixed by #2775
Closed

Workflow controller pod labels do not match upstream #2774

tico24 opened this issue Jun 18, 2024 · 0 comments · Fixed by #2775
Assignees
Labels
argo-workflows bug Something isn't working

Comments

@tico24
Copy link
Member

tico24 commented Jun 18, 2024

Describe the bug

The Workflow Controller deployment in the official release manifests get one label on the resulting pod: app: workflow-controller
The Workflow Controller deployment in the helm chart gets these labels:

app.kubernetes.io/name: {{ include "argo-workflows.name" .context }}-{{ .name }}
app.kubernetes.io/instance: {{ .context.Release.Name }}
app.kubernetes.io/component: {{ .component }}

is there a historical reason why the helm chart differs from upstream?

Any objections if I added app: workflow-controller to the helm chart (probably taking .component as the value?

Related helm chart

argo-workflows

Helm chart version

0.41.10

To Reproduce

Install.
Stare at the resulting labels on the controller pod.

Expected behavior

I would expect the helm chart to match upstream where possible.

Screenshots

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants