Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-workflows): add app: label to components to match upstream #2775

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Jun 18, 2024

Closes #2774

Here's the resulting labels on the controller pod when running a default install on this pr:

  template:
    metadata:
      labels:
        helm.sh/chart: argo-workflows-0.41.10
        app.kubernetes.io/name: argo-workflows-workflow-controller
        app.kubernetes.io/instance: release-name
        app.kubernetes.io/component: workflow-controller
        app: workflow-controller
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/part-of: argo-workflows
        app.kubernetes.io/version: "v3.5.8"
    spec:

Nothing has been removed so I don't believe this is a breaking change.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

tico24 and others added 5 commits March 4, 2024 08:08
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 self-assigned this Jun 18, 2024
@tico24 tico24 marked this pull request as ready for review June 18, 2024 11:09
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🚀

renovate.json Outdated Show resolved Hide resolved
Signed-off-by: Tim Collins <tim@thecollins.team>
@github-actions github-actions bot added size/XS and removed size/S labels Jun 19, 2024
@tico24 tico24 requested a review from mkilchhofer June 19, 2024 06:37
@mkilchhofer mkilchhofer merged commit 8130224 into argoproj:main Jun 19, 2024
6 checks passed
jaimeph pushed a commit to jaimeph/argo-helm that referenced this pull request Jun 20, 2024
…argoproj#2775)

Signed-off-by: Jaime Pérez Halcón <jphalcon@gmail.com>
@tico24 tico24 deleted the match-labels branch September 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow controller pod labels do not match upstream
3 participants