Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-workflows): Align version label #2342

Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix(argo-workflows): Align version label #2342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6960873
fix(argo-workflows): Aligne version label
yu-croco Nov 12, 2023
a727136
Merge branch 'main' into fix-version-label
yu-croco Nov 15, 2023
d84f766
fix(argo-workflows): fix typo
yu-croco Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/argo-workflows/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v3.5.1
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 0.39.0
version: 0.39.1
icon: https://argoproj.github.io/argo-workflows/assets/logo.png
home: https://github.com/argoproj/argo-helm
sources:
Expand All @@ -17,4 +17,4 @@ annotations:
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: fixed
description: Accept multi auth mode for server.
description: Aligne version label
tico24 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion charts/argo-workflows/templates/controller/workflow-controller-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
namespace: {{ .Release.Namespace | quote }}
labels:
{{- include "argo-workflows.labels" (dict "context" . "component" .Values.controller.name "name" .Values.controller.name) | nindent 4 }}
app.kubernetes.io/version: {{ default (include "argo-workflows.defaultTag" .) .Values.controller.image.tag | trunc 63 | quote }}
app.kubernetes.io/version: {{ include "argo-workflows.controller_chart_version_label" . }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 app.kubernetes.io/version showed correct value as expected with the following values.

controller:
  serviceLabels:
    testing: "1234"
  image:
    registry: 1234.dkr.ecr.us-west-2.amazonaws.com
    repository: third-party/argoproj/workflow-controller
    tag: v3.5.0@sha256:dda36f7a872f463a68df04d72755c086eb193fa1645e1f099f1670dd5f99a277
  metricsConfig:
    enabled: true
server:
  image:
    registry: 1234.dkr.ecr.us-west-2.amazonaws.com
    repository: third-party/argoproj/argocli
    tag: v3.5.0@sha256:608b6d532b6a1ad4ae82b1e05ee844eb2f4fffe90a8524421f95e9355a7e4be1
  secure: true
  authMode: sso
image

{{- with .Values.controller.serviceLabels }}
{{ toYaml . | nindent 4 }}
{{- end }}
Expand Down