Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Use renovate to create PRs when upstream releases #2358

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Nov 28, 2023

oh boy..

So bad news first. this won't "just work". Someone with repo permissions will need to set up renovate, and probably polish off the final step of the github action (the one that pushes the changes back to the PR).z

Renovate should be available as an app for the repo, it was enabled for all argoproj projects to my knowedge.

What's all this then?

When set up, renovate will

  • create a PR whenever an upstream project releases something.
  • create the PR title in a format friendly to our linter
  • bump the chart version by +1 patch version
  • update the release notes

it won't:

  • Hunt for any changes in the upstream release (eg crd changes). You'll have to check out the branch and add to it.
  • automerge the pr into main
  • bump the chart version more than once (unless you add and remove labels from the PR, but you're not gonna do that.. right?)

Renovate is only set to look at the Chart.yaml files. Here's all the dependencies it sees:
image

(You can see in the above screenshot that it wants to bump workflows up a version.. I was using that for testing).

redis-ha is disabled to prevent PRs appearing that will bump it above upstream.

Once this is in, I'd strongly suggest enabling renovate on the .github directory. Some actions are out of date.

Here's a screenshot of a test PR. All of this was automated:

image

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Tim Collins <tim@thecollins.team>
@pdrastil
Copy link
Member

Hi - maybe we could also use this for dependencies or do we want to have renovate bot AND dependabot ?

@tico24
Copy link
Member Author

tico24 commented Nov 29, 2023

My dream would be to use this instead of dependabot long term, it's quite a lot better (IMO). But I'd like to roll it out reasonably gently so as to not rock the boat too much.

Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24
Copy link
Member Author

tico24 commented Dec 7, 2023

Ah there's a bug. It's bumping the chart version and sticking a 'v' on the front. Leave that with me.

edit: now resolved

tico24 and others added 2 commits December 7, 2023 07:34
.github/workflows/chart-version-bump.yml Outdated Show resolved Hide resolved
.github/workflows/chart-version-bump.yml Outdated Show resolved Hide resolved
.github/workflows/chart-version-bump.yml Outdated Show resolved Hide resolved
Signed-off-by: Tim Collins <tim@thecollins.team>
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM. Let's give this baby a try

@tico24 tico24 self-assigned this Dec 7, 2023
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎉

@yu-croco yu-croco merged commit d0e0ce7 into argoproj:main Dec 7, 2023
6 checks passed
@tico24 tico24 deleted the renovate-upstream branch December 7, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants