feat(argo-cd): Add Probes for redis

[Farfaday]

Resolves #2464

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[pdrastil]

Why do we need extra tpl file when templates are used used just once inside the ConfigMap and templating contains only redis container port? This can be placed inline with:

data:
  redis_liveness.sh: |
    response=$(
      redis-cli \
        -h localhost \
        -p {{ .Values.redis.containerPorts.redis }} \
        ping
    )
    if [ "$response" != "PONG" ] && [ "${response:0:7}" != "LOADING" ] ; then
      echo "$response"
      exit 1
    fi
    echo "response=$response"

[Farfaday]

Hi @pdrastil
I simply tried to stick to the same logic as in the redis-ha helm chart from DandyDeveloper.
See here: https://github.com/DandyDeveloper/charts/blob/master/charts/redis-ha/templates/_configs.tpl
If you prefer, I can move that to the ConfigMap as you proposed.

[mkilchhofer]

I'd also prefer to have it directly inside the ConfigMap (for simplicity). I think that the HA helm chart reuses the "script" depending on the mode you install it.

[Farfaday]

Hi,
I rebased my branch and moved the probes scripts directly into the ConfigMap.

[Farfaday]

Sorry, I had forgotten to bump the version.
Looks like someone needs to re-trigger the CI jobs :)
Thanks!

[mkilchhofer]

Change LGTM.

@yu-croco , @pdrastil and @jmeridth wdyt, shall we make it optionally (probes disabled by default) to be:

• 100% backward compatible
• in line with upstream

?

[yu-croco]

I agree with making it optional 🙋

[yu-croco]

This ConfigMap is created when if and .Values.redis.enabled (not $redisHa.enabled) , so we also need same condition to refer here ...? 👀

[Farfaday]

The whole deployment.yaml file is enclosed in that if , see line 2

[yu-croco]

Oh thank you!