-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-rollouts): Add rollout plugin gloo platform rbac #2404
Conversation
Signed-off-by: Brian Gottfried <bgottfried91@gmail.com>
- apiGroups: | ||
- networking.gloo.solo.io | ||
resources: | ||
- routetables | ||
verbs: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bgottfried91 , can you please give us the doc that you refer for this config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yu-croco - this resource is used for traffic delegation via RouteTables for Gloo Edge
Ref: https://docs.solo.io/gloo-edge/latest/introduction/traffic_management/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin is mentioned in values.yaml
Ref: https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-glooplatform/blob/main/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pdrastil , thank you for the info ! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yu-croco FYI - it seems that Gloo is adopting new Kubernetes Gateway API
Ref: https://github.com/solo-io/gloo/tree/v2.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a FYI, this addition is to support the plugin for Gloo Platform. There's a separate plugin for Gloo Edge, they're different APIs. We'll probably submit an update to support adding the RBAC for that plugin soon!
This is the overview page for Gloo Platform's traffic management (https://docs.solo.io/gloo-mesh-enterprise/latest/concepts/traffic-management/) and the API reference for it (https://docs.solo.io/gloo-mesh-enterprise/latest/reference/api/route_table/)
Petr's correct that GE builds on the Gateway API now though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the info :)
Hi @bgottfried91 , please fix failed CI (I think documentation will help you), otherwise LGTM. 👍 |
…n to README Signed-off-by: Brian Gottfried <bgottfried91@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM 🚀
Checklist: