-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): Use new Argo CD extension mechanism #2406
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
74e2b8d
feat(argo-cd): Use new Argo CD extension mechanism
yu-croco 030c33d
fix: pass CI
yu-croco a16af50
chore: add changelog
yu-croco d83b4dc
fix: remove unnecessary permission due to removed CRD
yu-croco af54232
Merge branch 'main' into use-new-extension-ecosystem
jmeridth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Test Argo CD extension | ||
crds: | ||
keep: false | ||
# Ref: https://github.com/argoproj-labs/argocd-extension-metrics?tab=readme-ov-file#install-ui-extension | ||
server: | ||
extensions: | ||
enabled: true | ||
extensionList: | ||
- name: extension-metrics | ||
env: | ||
- name: EXTENSION_URL | ||
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz | ||
- name: EXTENSION_CHECKSUM_URL | ||
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1574,29 +1574,41 @@ server: | |
# -- Specify postStart and preStop lifecycle hooks for your argo-cd-server container | ||
lifecycle: {} | ||
|
||
## Argo UI extensions | ||
## Argo CD extensions | ||
## This function in tech preview stage, do expect instability or breaking changes in newer versions. | ||
## Ref: https://github.com/argoproj-labs/argocd-extensions | ||
## Ref: https://github.com/argoproj-labs/argocd-extension-installer | ||
extensions: | ||
# -- Enable support for Argo UI extensions | ||
# -- Enable support for Argo CD extensions | ||
enabled: false | ||
|
||
## Argo UI extensions image | ||
## Argo CD extension installer image | ||
image: | ||
# -- Repository to use for extensions image | ||
repository: "ghcr.io/argoproj-labs/argocd-extensions" | ||
# -- Tag to use for extensions image | ||
tag: "v0.2.1" | ||
# -- Repository to use for extension installer image | ||
repository: "quay.io/argoprojlabs/argocd-extension-installer" | ||
# -- Tag to use for extension installer image | ||
tag: "v0.0.1" | ||
# -- Image pull policy for extensions | ||
# @default -- `""` (defaults to global.image.imagePullPolicy) | ||
imagePullPolicy: "" | ||
|
||
# -- Extensions for Argo CD | ||
# @default -- `[]` (See [values.yaml]) | ||
## Ref: https://github.com/argoproj-labs/argocd-extension-metrics#install-ui-extension | ||
extensionList: [] | ||
# - name: extension-metrics | ||
# env: | ||
# - name: EXTENSION_URL | ||
# value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz | ||
# - name: EXTENSION_CHECKSUM_URL | ||
# value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt | ||
Comment on lines
+1598
to
+1603
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
# -- Server UI extensions container-level security context | ||
# @default -- See [values.yaml] | ||
containerSecurityContext: | ||
runAsNonRoot: true | ||
readOnlyRootFilesystem: true | ||
allowPrivilegeEscalation: false | ||
runAsUser: 1000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got |
||
seccompProfile: | ||
type: RuntimeDefault | ||
capabilities: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Condition is so naive 🙃