Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Fix path order in AWS Ingress declaration #2531

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix(argo-cd): Fix path order in AWS Ingress declaration #2531

merged 3 commits into from
Feb 20, 2024

Conversation

fulcrum29
Copy link
Contributor

Fix path order to evaluate GRPc endpoint first

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@fulcrum29
fix(ingress-aws): Fix path order in AWS Ingress declaration
e45eea8 
Fix path order to evaluate GRPc endpoint first

Signed-off-by: fulcrum29 <35672150+fulcrum29@users.noreply.github.com>
@fulcrum29 fulcrum29 changed the title fix(ingress-aws): Fix path order in AWS Ingress declaration fix(argo-cd): Fix path order in AWS Ingress declaration Feb 20, 2024
@fulcrum29
Copy link
Contributor Author

fixes #2532

@fulcrum29
chore: update Chart version
13bd134 
Signed-off-by: fulcrum29 <35672150+fulcrum29@users.noreply.github.com>
@github-actions github-actions bot added size/S and removed size/XS labels Feb 20, 2024
@fulcrum29
chore: add aritfacthub description
15d7cf2 
Signed-off-by: fulcrum29 <35672150+fulcrum29@users.noreply.github.com>
@pdrastil pdrastil marked this pull request as ready for review February 20, 2024 11:15
@pdrastil pdrastil merged commit f198eec into argoproj:main Feb 20, 2024
6 checks passed
@pdrastil pdrastil mentioned this pull request Feb 20, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdrastil pdrastil pdrastil approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulcrum29 @pdrastil @mbevc1