feat(argo-workflows): Add ability to set .Values.namespaceOverride #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <yu.croco@gmail.com>
yu-croco
force-pushed
the
support-override-ns
branch
from
7c8a235
to
19a9f94
Compare
Signed-off-by: yu-croco <yu.croco@gmail.com>
yu-croco
commented
Mar 1, 2024
| @@ -189,3 +189,11 @@ Return the appropriate apiVersion for GKE resources | |||
| {{- print "cloud.google.com/v1beta1" -}} | |||
| {{- end -}} | |||
| {{- end -}} | |||
|
|
|||
| {{/* | |||
There was a problem hiding this comment.
yu-croco
changed the title
yu-croco
commented
Mar 1, 2024
charts/argo-workflows/Chart.yaml
Outdated
| version: 0.40.12 | ||
| version: 0.40.13 |
There was a problem hiding this comment.
better to bump minor version ...? 🤔
There was a problem hiding this comment.
It shouldn't be a breaking change, so I think you're ok.
tico24
approved these changes
Mar 1, 2024
jmeridth
approved these changes
Mar 3, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2534 .
Related to #2562
Checklist: