feat(argo-rollouts): Added Deployment labels to values.yaml #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpeters0n plesse sign your commits to adhere to DCO. Thank you for your contribution |
Signed-off-by: mpeters0n <2matthew.peterson@gmail.com>
mpeters0n
force-pushed
the
argo-rollouts-deployment-labels
branch
from
7bd6411
to
d1dd1ec
Compare
yu-croco
reviewed
Mar 20, 2024
Signed-off-by: mpeters0n <2matthew.peterson@gmail.com>
mpeters0n
commented
Mar 20, 2024
| @@ -10,6 +10,9 @@ metadata: | |||
| name: {{ include "argo-rollouts.fullname" . }} | |||
| namespace: {{ .Release.Namespace | quote }} | |||
| labels: | |||
| {{- range $key, $value := (mergeOverwrite (deepCopy .Values.global.deploymentLabels) .Values.controller.deploymentLabels) }} | |||
| {{ $key }}: {{ $value | quote }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
I tested this with both .Values.global.deploymentLabels defined and undefined to verify backwards compatibility
yu-croco
approved these changes
Mar 20, 2024
mkilchhofer
approved these changes
Mar 23, 2024
Signed-off-by: Matthew Peterson <51802441+mpeters0n@users.noreply.github.com>
This seems to be a bug in the GitHub merge conflict editor Signed-off-by: Matthew Peterson <51802441+mpeters0n@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company enforces Deployment labels to track team ownership, cost allocations, etc.
Checklist: