feat(argo-cd): represent cluster credentials as a map

[nbarrientos]

Closes #2592.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

I'll re-generate the docs and bump the version if this change request goes forward. This contains non-backwards compatible changes. The rationale for this change is in the issue it closes.

Thanks for considering it.

[nbarrientos]

Similar breaking change recently accepted: 237493a

#2523

[jgranieczny]

Hi, any news on this? I would be very useful for us.

[pdrastil]

Hi, I'm for getting this in main. As this is breaking change for lots of people I would personally bundle this with another breaking things in next major release or do it as 2 phase process where old / new implementation lives side by side and old one will be removed later.

[nbarrientos]

Thanks! Fine for me to bundle with more breaking changes in the future; we're okay with keeping a local fork in the meantime.

[mkilchhofer]

Hi, I'm for getting this in main. As this is breaking change for lots of people I would personally bundle this with another breaking things in next major release or do it as 2 phase process where old / new implementation lives side by side and old one will be removed later.

We can also create multiple breaking change, IMHO we do not need to wait. But I am fine with both :)

[nbarrientos]

Wondering if we could give this a push this week? :)

[mbevc1]

There are some conflicts that needs resolving as well

[nbarrientos]

Yes, no worries, I'll fix that once somebody gives me the green light. I'd rather to avoid having to fix them several times.

[mkilchhofer]

🟢 from my side 👍

[mbevc1]

Same ✔️

[nbarrientos]

Conflicts resolved, version bumped to 7.0.0 due to the backwards-incompatible change.

[mkilchhofer]

Line 10 and 14 also requires changes

• {{- with .labels }}
• {{- with .annotations }}

[nbarrientos]

Line 10 and 14 also requires changes

* `{{- with .labels }}`

* `{{- with .annotations }}`

Thanks for the review.

I've added the requested changes, however it seems to work as expected (Helm v3.14.3) without specifying the scope in the with block. Perhaps inside the range, within the with block the context expands to all the local variables (in that case $cluster_key and $cluster_value).

With these values:

configs:
  clusterCredentials:
    mycluster2:
      server: https://mycluster2.example.com
      labels:
        foo: bar
      annotations:
        bar: foo
      namespaces: namespace1,namespace2
      clusterResources: true
      config:
        bearerToken: "<authentication token>"
        tlsClientConfig:
          insecure: false
          caData: "<base64 encoded certificate>"

The Secret object renders fine (both the labels and the annotations are included) with and without the modifications.

[mkilchhofer]

Thanks a lot @nbarrientos 🙏