Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Upgrade argocd to 2.11.0 + crd changes #2681

Merged
merged 4 commits into from
May 8, 2024
Merged

feat(argo-cd): Upgrade argocd to 2.11.0 + crd changes #2681

merged 4 commits into from
May 8, 2024

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented May 7, 2024 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@DrFaust92
bump to 2.11.0
097de4d 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
bump to 2.11.0
5c7ff1c 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92
bump to 2.11.0
754068b 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@DrFaust92 DrFaust92 marked this pull request as ready for review May 7, 2024 19:22
@github-actions github-actions bot added the size/L label May 7, 2024
@DrFaust92 DrFaust92 requested a review from tico24 as a code owner May 7, 2024 19:22
@github-actions github-actions bot added argo-cd and removed size/L labels May 7, 2024
@tico24
Copy link
Member

tico24 commented May 7, 2024

There's other changes beyond just CRDs I'm afraid. I'm on mobile but I see appset controller rbac changes and some new env vars on various deployments.

@DrFaust92
Copy link
Contributor Author

tico24 thanks! checking and adding missing rbac

@DrFaust92
add ARGOCD_REVISION_CACHE_LOCK_TIMEOUT to repo server
cfa975c 
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@github-actions github-actions bot added the size/L label May 7, 2024
@DrFaust92
Copy link
Contributor Author

@tico24 i did not see any missing rbac. but i did find one missing env var which i have added as well

@pdrastil
Copy link
Member

pdrastil commented May 7, 2024

@DrFaust92 Hi thanks for the sync - I've checked with upstream and looks good.

@jmeridth
Copy link
Member

jmeridth commented May 7, 2024

@pdrastil @tico24 this replaces #2680 correct?

@mkilchhofer mkilchhofer mentioned this pull request May 8, 2024
Closed
1 task
@mkilchhofer mkilchhofer merged commit 1098ce1 into argoproj:main May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@pdrastil pdrastil pdrastil approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DrFaust92 @tico24 @pdrastil @jmeridth @mkilchhofer @mbevc1 @yu-croco