Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(argo-cd): add nodeselector and tolerations to redis-secret-init job #2708

Merged
merged 1 commit into from
May 22, 2024
Merged

chore(argo-cd): add nodeselector and tolerations to redis-secret-init job #2708

merged 1 commit into from
May 22, 2024

Conversation

pavankumar-go
Copy link
Contributor

@pavankumar-go pavankumar-go commented May 22, 2024 •
edited
Loading

Add nodeselector and tolerations to redis-secret-init job

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

tico24
tico24 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once you sort your DCO out

mkilchhofer
mkilchhofer approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @pavankumar-go

You need to update the docs via "helm-docs" resp. scripts/helm-docs.sh

@tico24
Copy link
Member

tico24 commented May 22, 2024

ah the linter is correct. You need to re-generate the docs I think.

@yu-croco
Copy link
Collaborator

yu-croco commented May 22, 2024 •
edited
Loading

Hi @pavankumar-go , thank you for your PR.
Can you please update README by running ./scripts/helm-docs.sh ?
Then maybe CI will pass 🤔

[updated]
Everyone already mentioned earlier.. 🙈

@pavankumar-go
Copy link
Contributor Author

@mkilchhofer @yu-croco oops I missed that. let me update it

@pavankumar-go
chore(argo-cd): add nodeselector and tolerations to redis-secret-init…
60b8f2b 
…-job

Signed-off-by: Pavan <borntofight090@gmail.com>
@mkilchhofer mkilchhofer merged commit f431e9b into argoproj:main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@tico24 tico24 tico24 approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavankumar-go @tico24 @yu-croco @mkilchhofer