Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Make redis secret initialization optional #2713

Merged
merged 2 commits into from
May 23, 2024
Merged

feat(argo-cd): Make redis secret initialization optional #2713

merged 2 commits into from
May 23, 2024

Conversation

michaelvl
Copy link
Contributor

@michaelvl michaelvl commented May 23, 2024 •
edited
Loading

This PR makes it possible to disable the redis secret initialization job and manage the secret using alternative means.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@michaelvl
Make redis secret initialization optional
ad09f9c 
Signed-off-by: michaelvl <mvl.gh@network42.dk>
@michaelvl michaelvl changed the title Make redis secret initialization optional feat(argo-cd): Make redis secret initialization optional May 23, 2024
mkilchhofer
mkilchhofer requested changes May 23, 2024
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM 👍

charts/argo-cd/Chart.yaml Outdated
Comment on lines 29 to 30
- kind: added
description: Added priorityClassName for the redis secret init job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the lines from the previous change? (Only the current change [yours] needs to exists inside this structure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done!

@michaelvl
Remove artifacthub.io/changes from previous change
90178be 
Signed-off-by: michaelvl <mvl.gh@network42.dk>
mkilchhofer
mkilchhofer approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you @michaelvl

@yu-croco yu-croco merged commit 728b6e7 into argoproj:main May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelvl @mkilchhofer @yu-croco