Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(github): Charts use Helm "Capabilities" #2730

Merged
merged 1 commit into from
May 31, 2024
Merged

docs(github): Charts use Helm "Capabilities" #2730

merged 1 commit into from
May 31, 2024

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented May 31, 2024 •
edited
Loading

We recently had a few issues / PR proposals to make the chart more complex with features already provided by Helm (and the surrounding tools).
Let's make a clear statement and add some examples on how customers can use it.

Related PR(s):

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@mkilchhofer
docs(github): Charts use Helm "Capabilities"
2df9b4f 
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
yu-croco
yu-croco approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mbevc1 mbevc1 merged commit 0a97419 into main May 31, 2024
9 checks passed
@mbevc1 mbevc1 deleted the docs_regarding_helm_capabilities branch May 31, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil

@vladlosev vladlosev Awaiting requested review from vladlosev

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkilchhofer @mbevc1 @yu-croco @tico24