-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(argo-cd): remove secretName for server and applicationSet Certificates #2741
fix(argo-cd): remove secretName for server and applicationSet Certificates #2741
Conversation
…applicationset are static Signed-off-by: Erwan Vallienne <erwan@fgtech.fr>
The default values that are assigned match the default values. You do not need to have them in your values.yaml and the default values will be set. I'm not a fan of this PR but await feedback from other maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strict opinion here. I am fine with both.
But the changelog is wrong (you mentioned the wrong parameters).
Closing and reopening to see if DCO kicks off (was off and is on again) |
Queue might be backed up still due to dcoapp/app#211. Can try again later. |
UPDATE: Confirmed. DCO firing again. Thanks @mkilchhofer @erwanval when you make the changes requested by @mkilchhofer, maybe a new commit will trigger the DCO app. We'll see. |
Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
Signed-off-by: Erwan Vallienne <erwan@fgtech.fr>
If you keep the default, it works indeed. However, any other values than the default will be ignored, and the application will generate its own self-signed certificate instead. It still starts without error in appearance, but can cause confusion since the exposed cert doesn't match the one you configured. @mkilchhofer Thanks for fixing the typo in changelog. |
Hi @erwanval , can you please resolve conflict? |
Signed-off-by: Erwan Vallienne <135604788+erwanval@users.noreply.github.com>
@yu-croco done, thanks |
Signed-off-by: Erwan Vallienne <135604788+erwanval@users.noreply.github.com>
argocd-server and argocd-applicationset are expecting a secret with a predefined name, so having the option to set a custom name for the secret is confusing.
Related Issue:
#2724
Checklist: