Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(argocd-image-updater): fix referenced URL to command line reference page #2761

Merged
merged 3 commits into from
Jun 14, 2024
Merged

chore(argocd-image-updater): fix referenced URL to command line reference page #2761

merged 3 commits into from
Jun 14, 2024

Conversation

z63d
Copy link
Contributor

@z63d z63d commented Jun 12, 2024 •
edited
Loading

fix referenced URL to command line reference page in the comment in values.yaml.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

yu-croco
yu-croco requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @z63d thank you for your PR.
Please handle items in PR description.

@z63d
fix referenced URL
fff8293 
Signed-off-by: z63d <kaita.nakamura0830@gmail.com>
@z63d z63d force-pushed the fix-argocd-image-updater-referenced-url branch from 2f8f82f to fff8293 Compare June 13, 2024 00:51
@z63d z63d requested a review from yu-croco June 13, 2024 01:04
yu-croco
yu-croco approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM.

@yu-croco yu-croco merged commit ea967df into argoproj:main Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

Assignees
No one assigned
Labels
argocd-image-updater size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z63d @yu-croco @tico24