Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): Add secrettemplate to argo-cd server certificate #2780

Merged
merged 6 commits into from
Jun 19, 2024

Conversation

julieims
Copy link
Contributor

@julieims julieims commented Jun 19, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
@julieims julieims changed the title feat(argo-cd):Add secrettemplate to argo-cd server certificate feat(argo-cd): Add secrettemplate to argo-cd server certificate Jun 19, 2024
@julieims julieims changed the title feat(argo-cd): Add secrettemplate to argo-cd server certificate feat: Add secrettemplate to argo-cd server certificate Jun 19, 2024
@julieims julieims changed the title feat: Add secrettemplate to argo-cd server certificate feat(argo-cd): Add secrettemplate to argo-cd server certificate Jun 19, 2024
@julieims julieims marked this pull request as ready for review June 19, 2024 10:51
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
@yu-croco
Copy link
Collaborator

Hi @julieims , thank you for your PR.

Please handle this, one of the items in PR description.

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@mbevc1 mbevc1 merged commit e34b45b into argoproj:main Jun 19, 2024
6 checks passed
jaimeph pushed a commit to jaimeph/argo-helm that referenced this pull request Jun 20, 2024
…proj#2780)

* Add secrettemplate to argo-cd server certificate

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

* refactor documentation

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

* added changelog

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

* remove empty line

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

* correct comment in values file

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

* move documentation comment according to test results

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>

---------

Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Jaime Pérez Halcón <jphalcon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants