-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): Add secrettemplate to argo-cd server certificate #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
julieims
changed the title
feat(argo-cd):Add secrettemplate to argo-cd server certificate
feat(argo-cd): Add secrettemplate to argo-cd server certificate
Jun 19, 2024
julieims
changed the title
feat(argo-cd): Add secrettemplate to argo-cd server certificate
feat: Add secrettemplate to argo-cd server certificate
Jun 19, 2024
julieims
changed the title
feat: Add secrettemplate to argo-cd server certificate
feat(argo-cd): Add secrettemplate to argo-cd server certificate
Jun 19, 2024
julieims
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
June 19, 2024 10:51
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
Signed-off-by: Ims, Julie <juliebergeims@gmail.com>
yu-croco
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM.
mbevc1
approved these changes
Jun 19, 2024
jaimeph
pushed a commit
to jaimeph/argo-helm
that referenced
this pull request
Jun 20, 2024
…proj#2780) * Add secrettemplate to argo-cd server certificate Signed-off-by: Ims, Julie <juliebergeims@gmail.com> * refactor documentation Signed-off-by: Ims, Julie <juliebergeims@gmail.com> * added changelog Signed-off-by: Ims, Julie <juliebergeims@gmail.com> * remove empty line Signed-off-by: Ims, Julie <juliebergeims@gmail.com> * correct comment in values file Signed-off-by: Ims, Julie <juliebergeims@gmail.com> * move documentation comment according to test results Signed-off-by: Ims, Julie <juliebergeims@gmail.com> --------- Signed-off-by: Ims, Julie <juliebergeims@gmail.com> Signed-off-by: Jaime Pérez Halcón <jphalcon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: