Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): make PrometheusRule deployment conditional on CRD exis… #2791

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mcanevet
Copy link
Contributor

@mcanevet mcanevet commented Jun 24, 2024

…tence

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

…tence

Signed-off-by: Mickaël Canévet <mickael.canevet@jellysmack.com>
@mcanevet mcanevet force-pushed the feature-prometheusrule-condition branch from 312db7a to e418b71 Compare June 24, 2024 11:36
@tico24 tico24 merged commit ad8d48c into argoproj:main Jun 25, 2024
7 checks passed
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants