-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(argo-rollouts): Fix of global subscriptions for Argo Rollouts #2797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I should've checked existing code in previous PR.🫠
LGTM.
Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>
Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>
Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>
Signed-off-by: Yurii Bychenok <bychenok.y@ajax.systems>
Updated doc with |
Signed-off-by: Aikawa <yu.croco@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM
Fix to these changes #2793 which previously seems was not tested.
Checklist: