Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): allow applicationset-controller listing appprojects #2814

Closed
wants to merge 1 commit into from

Conversation

eripa
Copy link

@eripa eripa commented Jul 8, 2024

This is required by the 2.12.0 version of Argo CD

resolves #2813

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@eripa eripa changed the title fix(argo-cd): allow pplicationset-controller listing appprojects fix(argo-cd): allow applicationset-controller listing appprojects Jul 8, 2024
This is required by the 2.12.0 version of Argo CD

Signed-off-by: Eric Ripa <eric@ripa.io>
@pdrastil
Copy link
Member

pdrastil commented Jul 8, 2024

Hi @eripa thanks for contribution but this PR is for unreleased version of Argo CD. Usually we need to do much more than just bump image version when new minor version is officially released (CRDs, sync of new env variables, RBAC, etc.). If you can please wait a little bit longer until upstream cuts official 2.12.0 release and we will port all necessary changes.

@eripa
Copy link
Author

eripa commented Jul 8, 2024

Thanks for the quick reply @pdrastil, no problem. I'll run with a patch locally for now.

@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Jul 8, 2024
@jsolana
Copy link

jsolana commented Jul 9, 2024

My bad! I can see you also fix it here but I duplicated here --> #2819

@eripa Im missing here watch permissions (and update clusterrole.yaml too) If you update your MR I can close mine :)

Thanks!

@pdrastil
Copy link
Member

pdrastil commented Jul 9, 2024

Hi @eripa - I've created draft for upcoming release that you can try. See PR #2820

I'll close this as fix will be part of the release.

@pdrastil pdrastil closed this Jul 9, 2024
@eripa eripa deleted the 2.12.0-applicationset branch July 9, 2024 13:44
@eripa
Copy link
Author

eripa commented Jul 9, 2024

Thank you!

@jsolana
Copy link

jsolana commented Jul 9, 2024

Hi @pdrastil !
We can do the same (close in favor of #2820) with #2819 correct?

@pdrastil
Copy link
Member

pdrastil commented Jul 9, 2024

Hi @jsolana - yes all fixes for future release should go to that upgrade / draft PR. As people are already playing with RC3 I've put a draft out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.12 support: ApplicationSet Role cannot list resource "appprojects" in API group "argoproj.io"
4 participants