Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Address inconsistent redis-secret-init SA handling #2823

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(argo-cd): Address inconsistent redis-secret-init SA handling #2823

merged 1 commit into from
Jul 11, 2024

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Jul 11, 2024 •
edited
Loading

Fixes #2810

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@mkilchhofer
fix(argo-cd): Address inconsistent redis-secret-init SA handling
2b67a1f 
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@yu-croco yu-croco merged commit 2653aef into main Jul 11, 2024
7 checks passed
@yu-croco yu-croco deleted the bugfix/argo-cd_secret-init_serviceaccount branch July 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redisSecretInit.serviceAccount.create and redisSecretInit.serviceAccount.name have unintended behavior
3 participants
@mkilchhofer @mbevc1 @yu-croco