fix(argo-rollouts): Align permissions for controller's ClusterRole / Role #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-croco
commented
Jul 13, 2024
| - update | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} |
There was a problem hiding this comment.
Clusterrole has {{- with .Values.providerRBAC.additionalRules }} block and Role doesn't have it, so I thought it's better to merge into a single definition.
There was a problem hiding this comment.
Suggested change
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} | |
| {{- include "argo-rollouts.controller.roleRules" . | nindent 2 }} |
There was a problem hiding this comment.
Thank you for reviewing. Fixed in eba2e52 😇
…Role Signed-off-by: yu-croco <yu.croco@gmail.com>
yu-croco
force-pushed
the
align-permission
branch
from
190f326 to
247d989
Compare
yu-croco
force-pushed
the
align-permission
branch
from
7cfcc7f to
c1cc19c
Compare
jmeridth
approved these changes
Aug 10, 2024
mkilchhofer
approved these changes
Aug 12, 2024
| {{ toYaml . }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} |
There was a problem hiding this comment.
Suggested change
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} | |
| {{- include "argo-rollouts.controller.roleRules" . | nindent 2 }} |
| {{/* | ||
| Return the rules for controller's Role and ClusterRole | ||
| */}} | ||
| {{- define "argo-rollouts.controller.roleRuls" -}} |
There was a problem hiding this comment.
Suggested change
| {{- define "argo-rollouts.controller.roleRuls" -}} | |
| {{- define "argo-rollouts.controller.roleRules" -}} |
| - update | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} |
There was a problem hiding this comment.
Suggested change
| {{- include "argo-rollouts.controller.roleRuls" . | nindent 2 }} | |
| {{- include "argo-rollouts.controller.roleRules" . | nindent 2 }} |
Signed-off-by: yu-croco <yu.croco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions for controller's clusterrole and role are supposed to be same, but there is an unintended diff. So I merged the permissions into a single definition for DRY.
Checklist: