Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Fix Redis race condition due to optional REDIS_PASSWORD #2839

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

yu-croco
Copy link
Collaborator

@yu-croco yu-croco commented Jul 21, 2024

Resolves #2836

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco yu-croco marked this pull request as ready for review July 21, 2024 22:42
@yu-croco yu-croco marked this pull request as draft July 21, 2024 22:42
@kad-vriese1
Copy link

When will this PR be merged? At this moment ArgoCD does not function after an inital install. A restart of the deployments helps as a workaround but it would be nice if this PR was merged.

@tico24
Copy link
Member

tico24 commented Aug 8, 2024

Is this still a draft @yu-croco? That's why I've been avoiding reviewing.

@yu-croco yu-croco marked this pull request as ready for review August 8, 2024 13:34
@yu-croco
Copy link
Collaborator Author

yu-croco commented Aug 8, 2024

I've been waiting for the reply in #2836 (comment), but we cannot get it. So let us go proceed.

@mbevc1
Copy link
Collaborator

mbevc1 commented Aug 8, 2024

If we cannot get a reply, I agree let's go ahead and merge this. Feels like the risk is fairly low.

@mbevc1 mbevc1 merged commit 817182b into argoproj:main Aug 8, 2024
6 checks passed
@kad-vriese1
Copy link

Thank you!

Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rouke-broersma referenced this pull request in broersma-forslund/homelab Aug 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [argo-cd](https://github.com/argoproj/argo-helm) | patch | `7.4.1`
-> `7.4.2` |

---

### Release Notes

<details>
<summary>argoproj/argo-helm (argo-cd)</summary>

###
[`v7.4.2`](https://github.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.2)

A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool
for Kubernetes.

##### What's Changed

- fix(argo-cd): Fix Redis race condition due to optional REDIS_PASSWORD
by [@&#8203;yu-croco](https://github.com/yu-croco) in
[https://github.com/argoproj/argo-helm/pull/2839](https://github.com/argoproj/argo-helm/pull/2839)

**Full Changelog**:
argoproj/argo-helm@argo-cd-7.4.1...argo-cd-7.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/broersma-forslund/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@purajit
Copy link

purajit commented Aug 14, 2024

Btw, this didn't fix #2836 from what I can tell (see comments there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional REDIS_PASSWORD env variable cause race condition and Redis NOAUTH failures
6 participants