Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Set TTL on redis-secret-init Job #2861

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

jkleinlercher
Copy link
Contributor

@jkleinlercher jkleinlercher commented Aug 3, 2024

set ttlSecondsAfterFinished to prevent stuck during sync when managed by argocd

should fix argoproj/argo-cd#6880 (comment)


Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

…anaged by argocd

Signed-off-by: Johannes Kleinlercher <johannes@kleinlercher.at>
@tico24
Copy link
Member

tico24 commented Aug 3, 2024

Thanks for your PR. Please address the title formatting, the chart version and changelog (essentially the tick boxes in the description of your PR). I have moved this PR back to draft while you work on it.

@tico24 tico24 marked this pull request as draft August 3, 2024 19:03
@jkleinlercher jkleinlercher changed the title feat: set ttlsecondsafterfinished to prevent stuck during sync when m… fix(argo-cd): set ttlsecondsafterfinished to prevent stuck during sync when m… Aug 5, 2024
Signed-off-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>
@jkleinlercher jkleinlercher marked this pull request as ready for review August 5, 2024 15:36
Signed-off-by: Johannes Kleinlercher <johannes@kleinlercher.at>
@jkleinlercher
Copy link
Contributor Author

Thanks for your PR. Please address the title formatting, the chart version and changelog (essentially the tick boxes in the description of your PR). I have moved this PR back to draft while you work on it.

@tico24 I think this PR is ready for a review

Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkilchhofer mkilchhofer changed the title fix(argo-cd): set ttlsecondsafterfinished to prevent stuck during sync when m… fix(argo-cd): Set TTL on redis-secret-init Job Aug 6, 2024
@tico24 tico24 merged commit 2251079 into argoproj:main Aug 6, 2024
9 checks passed
rouke-broersma referenced this pull request in broersma-forslund/homelab Aug 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [argo-cd](https://github.com/argoproj/argo-helm) | patch | `7.4.0`
-> `7.4.1` |

---

### Release Notes

<details>
<summary>argoproj/argo-helm (argo-cd)</summary>

###
[`v7.4.1`](https://github.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.1)

[Compare
Source](https://github.com/argoproj/argo-helm/compare/argo-cd-7.4.0...argo-cd-7.4.1)

A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool
for Kubernetes.

#### What's Changed

- fix(argo-cd): Set TTL on redis-secret-init Job by
[@&#8203;jkleinlercher](https://github.com/jkleinlercher) in
[https://github.com/argoproj/argo-helm/pull/2861](https://github.com/argoproj/argo-helm/pull/2861)

#### New Contributors

- [@&#8203;jkleinlercher](https://github.com/jkleinlercher) made their
first contribution in
[https://github.com/argoproj/argo-helm/pull/2861](https://github.com/argoproj/argo-helm/pull/2861)

**Full Changelog**:
argoproj/argo-helm@argo-cd-7.4.0...argo-cd-7.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/broersma-forslund/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@oponomarov-tu
Copy link

I'm still facing this issue even on v7.4.1. Attaching values.yaml for reference.

Details

controller:
  replicas: 1
  env:
    - name: ARGOCD_K8S_CLIENT_QPS
      value: "300"
    - name: ARGOCD_SYNC_WAVE_DELAY
      value: "30"
  resources:
    limits:
      memory: 3Gi
    requests:
      cpu: 1
      memory: 3Gi
repoServer:
  autoscaling:
    enabled: true
    minReplicas: 1
  resources:
    requests:
      cpu: "100m"
      memory: "1Gi"
    limits:
      memory: "1Gi"
applicationSet:
  replicaCount: 1
dex:
  enabled: false
server:
  autoscaling:
    enabled: true
    minReplicas: 1
  resources:
    requests:
      cpu: "100m"
      memory: "256Mi"
    limits:
      memory: "512Mi"
redis:
  enabled: false
redis-ha:
  enabled: true
  haproxy:
    enabled: true
    init:
      resources:
        requests:
          memory: 100Mi
          cpu: 10m
        limits:
          memory: 100Mi
    resources:
      requests:
        memory: 200Mi
        cpu: 15m
      limits:
        memory: 200Mi
  redis:
    resources:
      requests:
        memory: 500Mi
        cpu: 20m
      limits:
        memory: 1Gi
  sentinel:
    resources:
      requests:
        memory: 20Mi
        cpu: 10m
      limits:
        memory: 20Mi
  exporter:
    resources:
      requests:
        memory: 25Mi
        cpu: 5m
      limits:
        memory: 25Mi
  init:
    resources:
      requests:
        memory: 25Mi
        cpu: 25m
      limits:
        memory: 25Mi
configs:
  secret:
    githubSecret: "$github-argocd-webhook:webhook.github.secret"
  repositories:
    aws-public-ecr:
      name: aws-public-ecr
      type: helm
      url: public.ecr.aws
      enableOCI: "true"

@venkatamutyala
Copy link
Contributor

@oponomarov-tu i recommend opening a new github issue and just referencing this one

msvechla added a commit to msvechla/karpenter-provider-aws that referenced this pull request Aug 21, 2024
Fixes an argocd issue where helm hooks never finish syncing when they
have ttlSecondsAfterFinished set to 0.

See related argocd issue: argoproj/argo-cd#6880

Suggested workaround as implemented by argocd team: argoproj/argo-helm#2861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waiting for completion of hook and hook never succeds
5 participants