Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Add rights on applicationsets for application controller #2975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(argo-cd): Add rights on applicationsets for application controller #2975

wants to merge 1 commit into from
+11 −2

Conversation

OpenGuidou
Copy link

@OpenGuidou OpenGuidou commented Oct 11, 2024 •
edited
Loading

Fixes #2974

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@mbevc1
Copy link
Collaborator

mbevc1 commented Oct 11, 2024

Can you please update the changelog as well?

@OpenGuidou
Copy link
Author

Can you please update the changelog as well?

Done !

@github-actions github-actions bot added size/S and removed size/XS labels Oct 11, 2024
@mbevc1
Copy link
Collaborator

mbevc1 commented Oct 11, 2024 •
edited
Loading

Thanks for your contribution. This needs changing as well: https://github.com/argoproj/argo-helm/pull/2975/files#diff-16f38cd1a4674cb682ac9f015fbc1c1ff552f024a8f791c16de0de21a1f65771L28-L29

More on this: https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#changelog

@OpenGuidou
fix(argo-cd): Add rights on applicationsets for application controller
d541e9b 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
yu-croco
yu-croco reviewed Oct 11, 2024
View reviewed changes
charts/argo-cd/templates/argocd-application-controller/role.yaml
@@ -19,6 +19,7 @@ rules:
- argoproj.io
resources:
- applications
- applicationsets
Copy link
Collaborator

@yu-croco yu-croco Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OpenGuidou , thank you for your PR.
Since we follow upstream and we don't see the permission in v2.12.4. 🤔
Ref: https://github.com/argoproj/argo-cd/blob/v2.12.4/manifests/base/application-controller-roles/argocd-application-controller-role.yaml

Can you please make PR for upstream ? Once upstream releases as a new version, we also follow this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure !

@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Oct 11, 2024
@OpenGuidou
Copy link
Author

Upstream fix: argoproj/argo-cd#20352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-croco yu-croco yu-croco left review comments

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing rights on ApplicationSet resource for application controller service account
3 participants
@OpenGuidou @mbevc1 @yu-croco