fix: make new alb fullName field optional for backward compatability (#…

…2806) fix: make new field optional Signed-off-by: zachaller <zachaller@users.noreply.github.com>
argoproj · May 24, 2023 · 839f05d · 839f05d
1 parent 0322914
commit 839f05d
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/manifests/crds/rollout-crd.yaml b/manifests/crds/rollout-crd.yaml
@@ -3274,7 +3274,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                   loadBalancer:
@@ -3287,7 +3286,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                   stableTargetGroup:
@@ -3300,7 +3298,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                 type: object

diff --git a/manifests/install.yaml b/manifests/install.yaml
@@ -14508,7 +14508,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                   loadBalancer:
@@ -14521,7 +14520,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                   stableTargetGroup:
@@ -14534,7 +14532,6 @@ spec:
                         type: string
                     required:
                     - arn
-                    - fullName
                     - name
                     type: object
                 type: object

diff --git a/pkg/apiclient/rollout/rollout.swagger.json b/pkg/apiclient/rollout/rollout.swagger.json
@@ -704,7 +704,8 @@
           "type": "string"
         },
         "fullName": {
-          "type": "string"
+          "type": "string",
+          "title": "FullName is the full name of the resource\n+optional"
         }
       }
     },

diff --git a/pkg/apis/rollouts/v1alpha1/generated.proto b/pkg/apis/rollouts/v1alpha1/generated.proto
diff --git a/pkg/apis/rollouts/v1alpha1/openapi_generated.go b/pkg/apis/rollouts/v1alpha1/openapi_generated.go
diff --git a/pkg/apis/rollouts/v1alpha1/types.go b/pkg/apis/rollouts/v1alpha1/types.go
@@ -994,8 +994,10 @@ type ALBStatus struct {
 }
 
 type AwsResourceRef struct {
-	Name     string `json:"name" protobuf:"bytes,1,opt,name=name"`
-	ARN      string `json:"arn" protobuf:"bytes,2,opt,name=arn"`
+	Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
+	ARN  string `json:"arn" protobuf:"bytes,2,opt,name=arn"`
+	// FullName is the full name of the resource
+	// +optional
 	FullName string `json:"fullName" protobuf:"bytes,3,opt,name=fullName"`
 }