Skip to content

Commit

Permalink
fix logging rs name when update fails
Browse files Browse the repository at this point in the history
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
  • Loading branch information
zachaller committed Jan 22, 2024
1 parent 31fe59b commit c3e3421
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rollout/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func (c *rolloutContext) scaleReplicaSet(rs *appsv1.ReplicaSet, newScale int32,

rs, err = c.kubeclientset.AppsV1().ReplicaSets(rsCopy.Namespace).Update(ctx, rsCopy, metav1.UpdateOptions{})
if err != nil {
return scaled, rs, fmt.Errorf("error updating replicaset %s: %w", rs.Name, err)
return scaled, rs, fmt.Errorf("error updating replicaset %s: %w", rsCopy.Name, err)

Check warning on line 383 in rollout/sync.go

View check run for this annotation

Codecov / codecov/patch

rollout/sync.go#L383

Added line #L383 was not covered by tests
}
err = c.replicaSetInformer.GetIndexer().Update(rs)
if err != nil {
Expand Down

0 comments on commit c3e3421

Please sign in to comment.