feat: Allow Traffic shaping through header based routing for ALB #2214

perenesenko · 2022-08-25T22:32:29Z

Signed-off-by: Andrii Perenesenko andrii.perenesenko@gmail.com

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

github-actions · 2022-08-25T22:33:09Z

E2E Tests Published Test Results

  1 files   1 suites 57m 9s ⏱️
89 tests 83 ✔️ 3 💤 3 ❌
95 runs 87 ✔️ 3 💤 5 ❌

For more details on these failures, see this check.

Results for commit 58e26b4.

♻️ This comment has been updated with latest results.

github-actions · 2022-08-25T22:41:28Z

Go Published Test Results

1 766 tests 1 766 ✔️ 2m 34s ⏱️
  101 suites       0 💤
      1 files       0 ❌

Results for commit 58e26b4.

♻️ This comment has been updated with latest results.

codecov · 2022-08-26T22:25:04Z

Codecov Report

Merging #2214 (58e26b4) into master (669f961) will decrease coverage by 0.00%.
The diff coverage is 84.97%.

@@            Coverage Diff             @@
##           master    #2214      +/-   ##
==========================================
- Coverage   82.39%   82.38%   -0.01%     
==========================================
  Files         121      121              
  Lines       18099    18425     +326     
==========================================
+ Hits        14912    15179     +267     
- Misses       2417     2461      +44     
- Partials      770      785      +15

Impacted Files	Coverage Δ
rollout/trafficrouting/alb/alb.go	`78.25% <73.11%> (-4.86%)`	⬇️
ingress/alb.go	`93.40% <90.90%> (-3.15%)`	⬇️
pkg/apis/rollouts/validation/validation.go	`95.57% <95.65%> (-0.11%)`	⬇️
utils/ingress/wrapper.go	`92.32% <98.16%> (+2.48%)`	⬆️
utils/defaults/defaults.go	`89.10% <100.00%> (+0.43%)`	⬆️
utils/ingress/ingress.go	`100.00% <100.00%> (ø)`
rollout/trafficrouting/istio/controller.go	`50.81% <0.00%> (-1.63%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

…coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

utils/ingress/ingress.go

utils/ingress/wrapper.go

utils/ingress/ingress.go

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

sonarqubecloud · 2022-08-31T21:01:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
17 Code Smells

No Coverage information
8.9% Duplication

…oproj#2214) * Allow Traffic shaping through header based routing for ALB Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Fix test Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Increase coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: deprecate field Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: sort http paths Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Xijun Dai <daixijun1990@gmail.com>

…oproj#2214) * Allow Traffic shaping through header based routing for ALB Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Fix test Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Increase coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: deprecate field Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: sort http paths Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

…oproj#2214) * Allow Traffic shaping through header based routing for ALB Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Fix test Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Increase coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: deprecate field Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: sort http paths Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> (cherry picked from commit 4848fb1)

…oproj#2214) * Allow Traffic shaping through header based routing for ALB Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Fix test Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Increase coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: deprecate field Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: sort http paths Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

…oproj#2214) * Allow Traffic shaping through header based routing for ALB Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Fix test Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Allow Traffic shaping through header based routing for ALB. Increase coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: deprecate field Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * fix after review: sort http paths Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> (cherry picked from commit 4848fb1)

perenesenko changed the title ~~Allow Traffic shaping through header based routing for ALB~~ feat: Allow Traffic shaping through header based routing for ALB Aug 25, 2022

harikrongali requested a review from zachaller August 26, 2022 17:59

perenesenko marked this pull request as ready for review August 29, 2022 17:27

perenesenko added 3 commits August 29, 2022 11:05

Allow Traffic shaping through header based routing for ALB

4f01f54

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

Allow Traffic shaping through header based routing for ALB. Fix test

634f501

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

Allow Traffic shaping through header based routing for ALB. Increase …

5fef2dc

…coverage Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

perenesenko force-pushed the working-alb-debug branch from 265169f to 5fef2dc Compare August 29, 2022 18:06

zachaller requested changes Aug 30, 2022

View reviewed changes

utils/ingress/ingress.go Show resolved Hide resolved

utils/ingress/ingress.go Show resolved Hide resolved

utils/ingress/wrapper.go Show resolved Hide resolved

utils/ingress/wrapper.go Show resolved Hide resolved

utils/ingress/ingress.go Show resolved Hide resolved

perenesenko added 2 commits August 30, 2022 13:43

fix after review: deprecate field

f542ed2

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

fix after review: sort http paths

58e26b4

Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>

zachaller approved these changes Sep 8, 2022

View reviewed changes

zachaller added the ready-for-review Ready for final review label Sep 9, 2022

leoluz approved these changes Sep 13, 2022

View reviewed changes

leoluz merged commit 4848fb1 into argoproj:master Sep 13, 2022

zachaller mentioned this pull request Nov 7, 2022

feat: Allow Traffic shaping through header based routing ALB #2061

Closed

6 tasks

schlags mentioned this pull request Aug 16, 2023

Docs missing for AWS ALB Traffic Routing by Header Support #2958

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow Traffic shaping through header based routing for ALB #2214

feat: Allow Traffic shaping through header based routing for ALB #2214

perenesenko commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

codecov bot commented Aug 26, 2022 •

edited

Loading

sonarqubecloud bot commented Aug 31, 2022

feat: Allow Traffic shaping through header based routing for ALB #2214

feat: Allow Traffic shaping through header based routing for ALB #2214

Conversation

perenesenko commented Aug 25, 2022 • edited Loading

github-actions bot commented Aug 25, 2022 • edited Loading

E2E Tests Published Test Results

github-actions bot commented Aug 25, 2022 • edited Loading

Go Published Test Results

codecov bot commented Aug 26, 2022 • edited Loading

Codecov Report

sonarqubecloud bot commented Aug 31, 2022

perenesenko commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

github-actions bot commented Aug 25, 2022 •

edited

Loading

codecov bot commented Aug 26, 2022 •

edited

Loading