Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Traffic shaping through header based routing ALB #2061

Closed

Conversation

perenesenko
Copy link
Member

@perenesenko perenesenko commented May 31, 2022

Signed-off-by: Andrii Perenesenko andrii.perenesenko@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #2061 (a994c78) into master (3329626) will decrease coverage by 0.35%.
The diff coverage is 52.32%.

❗ Current head a994c78 differs from pull request most recent head bd971dd. Consider uploading reports for the commit bd971dd to get more accurate results

@@            Coverage Diff             @@
##           master    #2061      +/-   ##
==========================================
- Coverage   82.24%   81.88%   -0.36%     
==========================================
  Files         121      120       -1     
  Lines       17956    17673     -283     
==========================================
- Hits        14768    14472     -296     
- Misses       2419     2487      +68     
+ Partials      769      714      -55     
Impacted Files Coverage Δ
utils/defaults/defaults.go 84.86% <0.00%> (-3.80%) ⬇️
rollout/trafficrouting/alb/alb.go 55.45% <17.32%> (-27.66%) ⬇️
utils/ingress/ingress.go 92.14% <25.00%> (-7.86%) ⬇️
ingress/alb.go 91.30% <82.60%> (-5.25%) ⬇️
pkg/apis/rollouts/validation/validation.go 94.80% <94.44%> (-0.87%) ⬇️
utils/ingress/wrapper.go 91.43% <97.64%> (+2.18%) ⬆️
utils/unstructured/unstructured.go 55.93% <0.00%> (-18.40%) ⬇️
rollout/trafficrouting/traefik/traefik.go 79.59% <0.00%> (-2.77%) ⬇️
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3329626...bd971dd. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

@harikrongali harikrongali added this to the v1.3 milestone Jun 22, 2022
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
@zachaller zachaller modified the milestones: v1.3, v1.4 Jul 26, 2022
@perenesenko perenesenko force-pushed the header-based-traffic-alb branch from b9f8fe6 to bd971dd Compare July 28, 2022 22:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

@github-actions
Copy link
Contributor

Go Published Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bd971dd.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0

Results for commit bd971dd.

@perenesenko perenesenko deleted the header-based-traffic-alb branch August 25, 2022 23:35
@zachaller zachaller removed this from the v1.4 milestone Oct 13, 2022
@ssanders1449
Copy link
Contributor

@perenesenko - Why did you close this PR? We have a sceario where argo-rollouts is controlling an ALB, but we want requests from out test clients to always go to canary pods. Is there another way to do this?

@zachaller
Copy link
Collaborator

@ssanders1449 this was done in #2214

@chengxiaogong
Copy link

Can you provide an example like this? There were some issues with my testing here

@Borisakov
Copy link

Is there any documentation for it?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants