Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make new alb fullName field optional for backward compatability #2806

Merged
merged 1 commit into from
May 24, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented May 24, 2023

This field was added as non optional, when a rollout exists with the upper level item included in status new apply's of the resource fail because this status field is missing on them, making it optional fixes this.

This field was introduced in #2604

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller enabled auto-merge (squash) May 24, 2023 17:53
@github-actions
Copy link
Contributor

Go Published Test Results

1 983 tests   1 983 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit f0d444b.

@zachaller zachaller merged commit e8d1117 into argoproj:master May 24, 2023
zachaller added a commit that referenced this pull request May 24, 2023
…2806)

fix: make new field optional

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.5 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants