fix: spec.preserveUnknownFields must be explicitly false to allow upgrades from apiextensions.k8s.io/v1beta1 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 81.22% 81.22%
=======================================
Files 103 103
Lines 9180 9180
=======================================
Hits 7456 7456
Misses 1229 1229
Partials 495 495 Continue to review full report at Codecov.
|
…rades from apiextensions.k8s.io/v1beta1 Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
jessesuen
force-pushed
the
fix-explicit-preserveUnknownFields
branch
from
90b254d to
386a4b7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1067
After switching from v1beta1 to v1 CRD, the default value of
spec.preserveUnknownFieldsin Kubernetes went from true to false. Because this field is unmanaged in our previous and current set of manifests, when upgrading from the v1beta1 CRD version to v1, it would encounter the following error:This is because when the v1 CRD was attempted to be applied (over the existing v1beta1 version), K8s rejected the update stating the value must be false (since a v1 manifest was being applied). This change explicitly sets it to false so that upgrades can happen from v0.10 to v1.0
Also removes our removeDescriptions workaround now that
controller-genhas the ability to remove descriptions.Signed-off-by: Jesse Suen jesse_suen@intuit.com