Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiment): Allow service creation with configurable ports. Fixes #2233 #2257

Conversation

jeromeguiard
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Jerome Hayakawa-Guiard <jerome.guiard@gmail.com>
@jeromeguiard jeromeguiard force-pushed the add-support-for-service-creation branch from 86d401d to efca96e Compare September 21, 2022 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

Go Published Test Results

1 653 tests   1 652 ✔️  2m 20s ⏱️
   101 suites         0 💤
       1 files           1

For more details on these failures, see this check.

Results for commit 85e6333.

♻️ This comment has been updated with latest results.

Signed-off-by: Jerome Hayakawa-Guiard <jerome.guiard@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.9% 6.9% Duplication

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    1 files    1 suites   2h 9m 35s ⏱️
  89 tests 72 ✔️ 3 💤 14
171 runs  74 ✔️ 3 💤 94

For more details on these failures, see this check.

Results for commit 85e6333.

@alexef
Copy link
Member

alexef commented Oct 24, 2022

see also #2357 where I'm allowing the entire ServiceSpec to be configured, not only the ports.

@zachaller
Copy link
Collaborator

Closed by #2397

@zachaller zachaller closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants