Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stable tag conditionally #2480

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

34fathombelow
Copy link
Member

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

Go Published Test Results

1 690 tests   1 689 ✔️  2m 13s ⏱️
   105 suites         0 💤
       1 files           1

For more details on these failures, see this check.

Results for commit 4652bcf.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 81.67% // Head: 81.67% // No change to project coverage 👍

Coverage data is based on head (3167c9b) compared to base (84df738).
Patch has no changes to coverable lines.

❗ Current head 3167c9b differs from pull request most recent head 4652bcf. Consider uploading reports for the commit 4652bcf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2480   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         126      126           
  Lines       19124    19124           
=======================================
  Hits        15620    15620           
  Misses       2710     2710           
  Partials      794      794           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zachaller zachaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update docs

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 35m 5s ⏱️
  94 tests   89 ✔️ 3 💤 2
190 runs  182 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit 3167c9b.

♻️ This comment has been updated with latest results.

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller merged commit b30ada2 into argoproj:master Dec 15, 2022
@34fathombelow 34fathombelow deleted the tag-stable-optional branch December 15, 2022 15:18
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* chore: update stable tag conditionally

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

* updated requested changes

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* chore: update stable tag conditionally

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

* updated requested changes

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants