fix(ui): don't use Buffer for FNV hash (#11766)

ui/src/app/shared/pod-name.test.ts

@@ -8,6 +8,7 @@ describe('pod names', () => {
         expect(createFNVHash('You cannot alter your fate. However, you can rise to meet it.')).toEqual(827171719);
     });
 
+    // note: the below is intended to be equivalent to the server-side Go code in workflow/util/pod_name_test.go
     const nodeName = 'nodename';
     const nodeID = '1';
 

ui/src/app/shared/pod-name.ts

@@ -9,6 +9,7 @@ export const k8sNamingHashLength = 10;
 // getPodName returns a deterministic pod name
 // In case templateName is not defined or that version is explicitly set to  POD_NAME_V1, it will return the nodeID (v1)
 // In other cases it will return a combination of workflow name, template name, and a hash (v2)
+// note: this is intended to be equivalent to the server-side Go code in workflow/util/pod_name.go
 export const getPodName = (workflowName: string, nodeName: string, templateName: string, nodeID: string, version: string): string => {
     if (version !== POD_NAME_V1 && templateName !== '') {
         if (workflowName === nodeName) {
@@ -35,17 +36,17 @@ export const ensurePodNamePrefixLength = (prefix: string): string => {
 };
 
 export const createFNVHash = (input: string): number => {
-    const data = Buffer.from(input);
-
     let hashint = 2166136261;
 
-    /* tslint:disable:no-bitwise */
-    for (const character of data) {
+    for (let i = 0; i < input.length; i++) {
+        const character = input.charCodeAt(i);
+        /* tslint:disable:no-bitwise */
         hashint = hashint ^ character;
         hashint += (hashint << 1) + (hashint << 4) + (hashint << 7) + (hashint << 8) + (hashint << 24);
     }
 
     return hashint >>> 0;
+    /* tslint:enable:no-bitwise */
 };
 
 export const getTemplateNameFromNode = (node: NodeStatus): string => {