fix: close response body when request event-stream failed (#11818)

Signed-off-by: Thearas <thearas850@gmail.com>
argoproj · Sep 14, 2023 · 7aedf97 · 7aedf97
1 parent 62149a0
commit 7aedf97
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/apiclient/http1/facade.go b/pkg/apiclient/http1/facade.go
@@ -72,12 +72,13 @@ func (h Facade) EventStreamReader(in interface{}, path string) (*bufio.Reader, e
 			},
 		},
 	}
-	resp, err := client.Do(req) //nolint
+	resp, err := client.Do(req)
 	if err != nil {
 		return nil, err
 	}
 	err = errFromResponse(resp)
 	if err != nil {
+		resp.Body.Close()
 		return nil, err
 	}
 	return bufio.NewReader(resp.Body), nil