Skip to content

Commit

Permalink
Bug fixes in getting started (#1656)
Browse files Browse the repository at this point in the history
Mainly ensures that all commands run on the `argo` namespace
  • Loading branch information
simster7 authored and sarabala1979 committed Oct 8, 2019
1 parent ec78837 commit c6cddaf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions demo.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ To run all of the examples in this guide, the 'default' service account is too l
features such as artifacts, outputs, access to secrets, etc... For demo purposes, run the following
command to grant admin privileges to the 'default' service account in the namespace 'default':
```
kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=default:default
kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=argo:default
```
For the bare minimum set of privileges which a workflow needs to function, see
[Workflow RBAC](docs/workflow-rbac.md). You can also submit workflows which run with a different
Expand Down Expand Up @@ -90,11 +90,11 @@ helm install stable/minio \

Login to the Minio UI using a web browser (port 9000) after exposing obtaining the external IP using `kubectl`.
```
kubectl get service argo-artifacts-mini -o wide
kubectl get service argo-artifacts -o wide
```
On Minikube:
```
minikube service --url argo-artifacts-mini
minikube -n argo service --url argo-artifacts
```

NOTE: When minio is installed via Helm, it uses the following hard-wired default credentials,
Expand All @@ -116,7 +116,7 @@ data:
artifactRepository:
s3:
bucket: my-bucket
endpoint: argo-artifacts.default:9000
endpoint: argo-artifacts:9000
insecure: true
# accessKeySecret and secretKeySecret are secret selectors.
# It references the k8s secret named 'argo-artifacts'
Expand Down

0 comments on commit c6cddaf

Please sign in to comment.