Skip to content

Commit

Permalink
[Fix #1242] Failed DAG nodes are now kept and set to running on Retry…
Browse files Browse the repository at this point in the history
…Workflow. (#1250)
  • Loading branch information
cristianpop authored and jessesuen committed May 10, 2019
1 parent d5fe5f9 commit e58859d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions workflow/util/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,14 @@ func RetryWorkflow(kubeClient kubernetes.Interface, wfClient v1alpha1.WorkflowIn
continue
}
case wfv1.NodeError, wfv1.NodeFailed:
if !strings.HasPrefix(node.Name, onExitNodeName) && node.Type == wfv1.NodeTypeDAG {
newNode := node.DeepCopy()
newNode.Phase = wfv1.NodeRunning
newNode.Message = ""
newNode.FinishedAt = metav1.Time{}
newWF.Status.Nodes[newNode.ID] = *newNode
continue
}
// do not add this status to the node. pretend as if this node never existed.
default:
// Do not allow retry of workflows with pods in Running/Pending phase
Expand Down

0 comments on commit e58859d

Please sign in to comment.