Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade actions/upload-artifact and actions/download-artifact to V4 #12455

Open
Garett-MacGowan opened this issue Jan 4, 2024 · 6 comments
Open

Upgrade actions/upload-artifact and actions/download-artifact to V4 #12455

Garett-MacGowan opened this issue Jan 4, 2024 · 6 comments
Labels
area/build Build or GithubAction/CI issues github_actions Pull requests that update Github_actions dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request

Comments

@Garett-MacGowan
Copy link
Contributor

Garett-MacGowan commented Jan 4, 2024 •
edited
Loading

Summary

Once actions/download-artifact#249 is resolved, we can upgrade actions/[upload/download]-artifact to V4. The project is currently using V3 since downgrading from V4 due to the issue above.

Previously upgraded to V4 in #12384
Downgraded to V3 in #12454

Use Cases

V4 has some performance improvments which would be nice to integrate, but only once it is stable.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@Garett-MacGowan Garett-MacGowan added the type/feature Feature request label Jan 4, 2024
@Garett-MacGowan
Copy link
Contributor Author

Garett-MacGowan commented Jan 4, 2024 •
edited
Loading

@agilgur5 I've created this ticket to keep track of the eventual desire to upgrade after #12454 is merged.

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies github_actions Pull requests that update Github_actions dependencies area/build Build or GithubAction/CI issues labels Jan 4, 2024
@agilgur5 agilgur5 mentioned this issue Mar 9, 2024
Merged
2 tasks
@Garett-MacGowan
Copy link
Contributor Author

Garett-MacGowan commented Apr 5, 2024 •
edited
Loading

actions/download-artifact#249 has been closed but users are still reporting issues.

Edit: the issues being reported might not be related to the timeout issue that was claimed to be fixed: actions/download-artifact#249 (comment)

@Garett-MacGowan
Copy link
Contributor Author

Garett-MacGowan commented Apr 6, 2024 •
edited
Loading

@agilgur5 Based on this, it may be safe to upgrade to V4 now.

@agilgur5
Copy link
Contributor

agilgur5 commented Apr 6, 2024

🤔 The previous two comments have a ton of upvotes, so I'm not so sure about that...

@Garett-MacGowan
Copy link
Contributor Author

🤔 The previous two comments have a ton of upvotes, so I'm not so sure about that...

I'm definitely not sure, but based on the example failed action, the failure mode is different.

@Garett-MacGowan
Copy link
Contributor Author

Garett-MacGowan commented Apr 6, 2024 •
edited
Loading

@agilgur5 You're probably right. Not stable enough to warrant the upgrade. Lets watch this.

@agilgur5 agilgur5 mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues github_actions Pull requests that update Github_actions dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agilgur5 @Garett-MacGowan