fix: CI Artifact Download Timeout. Fixes #12452 #12454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v3 to fix artifact download timeout issues. Add both download-artifact and upload-artifact to dependabot ignore dependency. Fixes argoproj#12452. Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>
Garett-MacGowan
changed the title
…2454 Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>
agilgur5
added
type/dependencies
agilgur5
reviewed
Jan 4, 2024
Add comment to ignore actions/download-artifact and actions/upload-artifact until actions/download-artifact/issues/249 is resolved. Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Garett MacGowan <garett.macgowan@gmail.com>
|
Seems to have reduced the error frequency, as expected. Good to go if tests succeed. |
agilgur5
approved these changes
Jan 4, 2024
Garett-MacGowan
changed the title
terrytangyuan
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12452
Motivation
The V4 actions seem to have a high tendency to timeout when downloading artifacts.
actions/download-artifact#249
Modifications
Downgrade actions/download-artifact and actions/upload-artifact from v4 to v3 to fix artifact download timeout issues. Add both download-artifact and upload-artifact to dependabot ignore dependency.
Verification
Submit a few empty commits to verify frequency of failures is reduced.