Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cronworkers not logged #13681

Closed
3 of 4 tasks
tooptoop4 opened this issue Sep 30, 2024 · 1 comment · Fixed by #13688
Closed
3 of 4 tasks

cronworkers not logged #13681

tooptoop4 opened this issue Sep 30, 2024 · 1 comment · Fixed by #13688
Labels
area/controller Controller issues, panics area/cron-workflows good first issue Good for newcomers P3 Low priority solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug

Comments

@tooptoop4
Copy link
Contributor

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

https://github.com/argoproj/argo-workflows/blob/v3.5.11/workflow/controller/controller.go#L279-L282 missing cronWorkflowWorkers

Version(s)

latest

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@agilgur5
Copy link
Contributor

Yea looks like that was missed in #11457

@agilgur5 agilgur5 added good first issue Good for newcomers area/controller Controller issues, panics area/cron-workflows P3 Low priority solution/suggested A solution to the bug has been suggested. Someone needs to implement it. labels Sep 30, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Sep 30, 2024
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Oct 1, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Oct 1, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
isubasinghe pushed a commit that referenced this issue Oct 30, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/cron-workflows good first issue Good for newcomers P3 Low priority solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants