Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Globally-defined logging to artifact repository #1790

Closed
irlevesque opened this issue Nov 22, 2019 · 2 comments · Fixed by #1860
Closed

[Feature Request] Globally-defined logging to artifact repository #1790

irlevesque opened this issue Nov 22, 2019 · 2 comments · Fixed by #1860
Assignees
Labels
good first issue Good for newcomers

Comments

@irlevesque
Copy link

Feature Request

As an administrator, I'd like to ensure that all cluster users' workflow logs are always persisted to our globally-defined artifact repository.

Problem

Currently, Argo requires Workflow developers to remember to add archiveLocation.archiveLogs: true to every template. This is error prone and doesn't provide compliance guarantees.

Solution

Provide a global logging option in the controller ConfigMap that enables archiveLogs globally, regardless of Workflow archiveLocation specification.

Refs

Slack discussion

@alexec
Copy link
Contributor

alexec commented Dec 16, 2019

This already partially works

Add this to your config map:

    # artifactRepository defines the default location to be used as the artifact repository for
    # container artifacts.
    artifactRepository:
      # archiveLogs will archive the main container logs as an artifact
      archiveLogs: true

Anything that uses uses artifacts will also archive logs.

If they do not use it, they do not archive logs.

@simster7
Copy link
Member

simster7 commented Mar 8, 2020

Also fixed with #2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
4 participants