Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid config can allow updateConfig to put controller in invalid state #2069

Closed
alexec opened this issue Jan 27, 2020 · 1 comment · Fixed by #2070
Closed

invalid config can allow updateConfig to put controller in invalid state #2069

alexec opened this issue Jan 27, 2020 · 1 comment · Fixed by #2070
Labels
type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented Jan 27, 2020

Summary

See #2066, it is possible for updateConfig to fail at various points leaving the controller in a potentially invalid or unrecoverable state.

Motivation

Avoid having the controller in a bad state.

Proposal

Rather than load the config, and then iterate over values returning an error part way thought, we should create and validate a replacement configuration and set it all at once.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexec alexec added the type/feature Feature request label Jan 27, 2020
@alexec
Copy link
Contributor Author

alexec commented Jan 27, 2020

Additionally, we ignore deletion for the cm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant