You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See #2066, it is possible for updateConfig to fail at various points leaving the controller in a potentially invalid or unrecoverable state.
Motivation
Avoid having the controller in a bad state.
Proposal
Rather than load the config, and then iterate over values returning an error part way thought, we should create and validate a replacement configuration and set it all at once.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered:
Summary
See #2066, it is possible for
updateConfig
to fail at various points leaving the controller in a potentially invalid or unrecoverable state.Motivation
Avoid having the controller in a bad state.
Proposal
Rather than load the config, and then iterate over values returning an error part way thought, we should create and validate a replacement configuration and set it all at once.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: