unclear documentation comments for persistence in workflow-controller-configmap.yaml

[eug48]

Currently workflow-controller-configmap.yaml has

      # save the entire workflow into etcd and DB
      nodeStatusOffLoad: false
      # save completed workloads to the archived, even if disabled, you'll be able to
      # read from the archive
      archive: false

Perhaps more clearer would be "nodeStatusOffLoad if false saves the entire workflow into both etcd and the persistence DB, if true node status is only saved to the persistence DB to avoid the 1MB limit in etcd".

For archive the wording appears to have a typo and is unclear about what can be read from the archive.

Thanks very much for all the great work!

[alexec]

See #2170

[eug48]

@alexec the linked PR does improve the comment for nodeStatusOffLoad, but not for archive

[alexec]

@alexec the linked PR does improve the comment for nodeStatusOffLoad, but not for archive

better now?

[eug48]

a bit better but what I still don't clearly understand is that if archive is false what gets stored in the persistence DB if nodeStatusOffLoad is false and if nodeStatusOffLoad true?

[alexec]

the two features are independent - the whole workflow is store in the archive, including any data that was offloaded (or not)

[eug48]

So if both nodeStatusOffLoad: false and archive: false then nothing is written to the persistence DB?

And if nodeStatusOffLoad: true and archive: false just the nodeStatus is temporarily written to the DB but then deleted?

[alexec]

correct - the node status is deleted when the workflow is deleted