Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Argo UI not indexed #2381

Closed
2 of 4 tasks
crenshaw-dev opened this issue Mar 6, 2020 · 2 comments
Closed
2 of 4 tasks

Make Argo UI not indexed #2381

crenshaw-dev opened this issue Mar 6, 2020 · 2 comments
Labels

Comments

@crenshaw-dev
Copy link
Member

Checklist:

  • I've included the version.
  • I've included reproduction steps.
  • I've included the workflow YAML.
  • I've included the logs.

What happened:

I noticed Argo UI doesn't prevent search engine indexing.

What you expected to happen:

I expected Argo UI to prevent search engine indexing. If someone leaves an Argo UI public-facing accidentally, we probably want it to be not super discoverable.

How to reproduce it (as minimally and precisely as possible):

Inspect the source code of the Argo UI. Search for noindex, and you won't find any results.

Anything else we need to know?:

Environment:

  • Argo version: 2.6.0

Message from the maintainers:

If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@simster7
Copy link
Member

simster7 commented Mar 6, 2020

Care to submit a PR? :)

@simster7
Copy link
Member

simster7 commented Mar 8, 2020

Closed with #2383

@simster7 simster7 closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants