Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resuming nodes #2546

Closed
alexec opened this issue Mar 30, 2020 · 1 comment
Closed

Resuming nodes #2546

alexec opened this issue Mar 30, 2020 · 1 comment
Labels

Comments

@alexec
Copy link
Contributor

alexec commented Mar 30, 2020

In #1893 the ability to resume nodes based on a "node field selector" was introduced. This included a test named TestNodeSuspendResume.

This test was sporadically failing on master, so in #2543 I increased the timeout from 10s to 20s. This actually made the test reliably fail, the exact opposite of what I expected.

This suggests that the test is probably valid - therefore there might be an underlying bug.

This is the error:

collins8@intuitdepe1a95 argo (⎈ |k3s-default:argo) (longer-timeout)]$ argo resume node-suspend --node-field-selector inputs.parameters.tag.value=suspend1-tag1
2020/03/30 13:29:40 Failed to resume node-suspend: rpc error: code = Unknown desc = No nodes matching nodeFieldSelector: inputs.parameters.tag.value=suspend1-tag1

Here is a failing build:

https://circleci.com/workflow-run/12abe0c3-7300-416d-a29f-79700d00b052

@alexec
Copy link
Contributor Author

alexec commented Mar 30, 2020

@mark9white I've created a bug and would love it if you could take a look.

@alexec alexec closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant