Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control over resuming suspended nodes #1893

Closed
markterm opened this issue Dec 26, 2019 · 3 comments
Closed

More control over resuming suspended nodes #1893

markterm opened this issue Dec 26, 2019 · 3 comments
Labels
type/feature Feature request

Comments

@markterm
Copy link
Contributor

markterm commented Dec 26, 2019

Summary

Enable the resume command/API to resume just nodes with arguments matching a parameter, and have the ability to set a suspended node to failure.

Motivation

In the case of a workflow triggering asynchronous execution, eg a third party service that uploads data to S3. At the end of the execution we would want to unsuspend just that specific node, and if the execution fails then we would want to be able to set it to failure. Currently this would generally be done via a pod that is polling the third-party service, but that's not optimal from a performance perspective.

Proposal

Add extra parameters to unsuspend API with an optional argument matching expression and an optional error message that would set the Suspend node to failure and record the message against the node.

@markterm markterm added the type/feature Feature request label Dec 26, 2019
@markterm markterm changed the title More control over un-suspension More control over resuming suspended nodes Dec 26, 2019
@simster7
Copy link
Member

Sounds like a good idea. Are you interested in submitting a PR for this?

@markterm
Copy link
Contributor Author

Yes, I'll be creating it within the next couple of weeks.

@markterm
Copy link
Contributor Author

markterm commented Jan 6, 2020

I've created #1904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants